Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear Repeat Structure Support for Formplayer #1567

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Linear Repeat Structure Support for Formplayer #1567

merged 7 commits into from
Jun 7, 2024

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Apr 16, 2024 •
edited
Loading

Product Description

JIra

Adds support for using both counted and non counted repeat groups in a single form on Web Apps.

Technical Summary

Spec

Safety Assurance

Safety story

  • Will go through QA once supporting changes are done on Web Apps
  • Unit tests are added to verify non counted repeat groups work correctly, there should not be any other impact of removing the non linear repeat strucuture

Automated test coverage

  • Added in PR

QA Plan

Notes here

QA ticket

Special deploy instructions

Should only be deployed after the corresponding Web Apps changes are deployed

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

cross_request: dimagi/commcare-core#1408

@shubham1g5 shubham1g5 added the awaiting QA QA in progress. Do not merge label Apr 16, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (1520efb) to head (f8157d4).

Files Patch % Lines
...org/commcare/formplayer/api/json/PromptToJson.java 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1567      +/-   ##
============================================
- Coverage     70.44%   70.10%   -0.35%     
  Complexity     2023     2023              
============================================
  Files           252      252              
  Lines          7833     7844      +11     
  Branches        722      723       +1     
============================================
- Hits           5518     5499      -19     
- Misses         2045     2071      +26     
- Partials        270      274       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

snopoke
snopoke reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to review this at the moment. I also don't have a good grasp of linear vs non linear repeat structures.

@shubham1g5 shubham1g5 mentioned this pull request May 6, 2024
Merged
3 tasks
@shubham1g5 shubham1g5 added QA Passed and removed awaiting QA QA in progress. Do not merge labels Jun 7, 2024
@shubham1g5 shubham1g5 merged commit 94af0d6 into master Jun 7, 2024
5 of 6 checks passed
@shubham1g5 shubham1g5 deleted the mixedRepeatGroup branch June 7, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snopoke snopoke snopoke left review comments

@MartinRiese MartinRiese MartinRiese approved these changes

@Robert-Costello Robert-Costello Awaiting requested review from Robert-Costello

@ctsims ctsims Awaiting requested review from ctsims

Assignees
No one assigned
Labels
QA Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shubham1g5 @snopoke @MartinRiese